[GitHub] [flink] Tartarus0zm commented on a diff in pull request #22949: [FLINK-32517][table] Support to execute [CREATE OR] REPLACE TABLE AS statement

Thu, 06 Jul 2023 02:02:53 -0700 


Tartarus0zm commented on code in PR #22949:
URL: https://github.com/apache/flink/pull/22949#discussion_r1254150082


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java:
##########
@@ -171,11 +171,7 @@ private CatalogTable createCatalogTable(SqlCreateTable 
sqlCreateTable) {
                         mergingStrategies);
         verifyPartitioningColumnsExist(mergedSchema, partitionKeys);
 
-        String tableComment =
-                sqlCreateTable
-                        .getComment()
-                        .map(comment -> 
comment.getValueAs(NlsString.class).getValue())
-                        .orElse(null);
+        String tableComment = 
OperationConverterUtils.getTableComment(sqlCreateTable.getComment());

Review Comment:
   Thank you for the reminder.
   I tested it in both UT and sql-client and it passed.
   
![image](https://github.com/apache/flink/assets/9247964/4237f611-5f96-42f7-bf2f-fc7dddc21566)
   
   
![image](https://github.com/apache/flink/assets/9247964/173a4088-38fd-465f-9cd6-e3fc54ff4abc)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to