RocMarshal commented on code in PR #22925:
URL: https://github.com/apache/flink/pull/22925#discussion_r1254535683
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -146,7 +146,9 @@ public class SourceOperator<OUT, SplitT extends
SourceSplit> extends AbstractStr
private DataOutput<OUT> lastInvokedOutput;
- private long lastEmittedWatermark = Watermark.UNINITIALIZED.getTimestamp();
+ private long latestWatermark = Watermark.UNINITIALIZED.getTimestamp();
+
+ private boolean isIdle = false;
Review Comment:
I have a minor comment unrelated to semantics here.
Assuming a method is needed to get `isIdle` value here, the method will be
called `getIsIdle()` or `isIsIdle()` or `isIdle()`?
I'm not sure if there is a clear variables-naming convention.
How about the variable `isIdle` -> `idle` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
