afedulov commented on code in PR #22810:
URL: https://github.com/apache/flink/pull/22810#discussion_r1254598882
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestClientTest.java:
##########
@@ -84,6 +89,26 @@ public void testConnectionTimeout() throws Exception {
}
}
+ @Test
+ public void testHttpsConnectionWithDefaultCerts() throws Exception {
+ final Configuration config = new Configuration();
+ final URL httpsUrl = new URL("https://raw.githubusercontent.com";);
Review Comment:
> given that the CI setup already won't function w/o that connection
This was exactly what I was thinking, however it is a very good point about
the local Unit tests execution. It is not optimal to put someone into the
position when they cannot run unit tests without an internet connection. How
about we move it into a Java-based E2E test (in `flink-end-to-end-tests`),
similar to `KafkaSourceE2ECase`. It will only be executed with the
`run-end-to-end-tests` profile enabled (in CI). I am a bit not sure about the
appropriate module name here. Maybe `flink-restclient-test` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
