XComp opened a new pull request, #22967: URL: https://github.com/apache/flink/pull/22967
## What is the purpose of the change We introduced contenderID in a lot of places with [FLINK-26522](https://issues.apache.org/jira/browse/FLINK-26522). The original multi-component leader election classes of [FLINK-24038](https://issues.apache.org/jira/browse/FLINK-24038) used componentId. Revisiting that naming made me realize that it's actually wrong. A contender is a specific instance of a component that participates in the leader election. A component, in this sense, is the more abstract concept. contenderID refers to an ID for the specific contender instance but the IDs we're sharing are actually referring to a Flink component and therefore, are the same between different contenders which compete for leadership for the same component. This contradicts the definition of an identifier. ## Brief change log Renames of all occurrences that match the case-insensitive regex `contender.?id`. ## Verifying this change Grep through the code for `contender.?id` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
