Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2700#discussion_r85533357
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -917,8 +917,15 @@ class JobManager(
case ScheduleOrUpdateConsumers(jobId, partitionId) =>
currentJobs.get(jobId) match {
case Some((executionGraph, _)) =>
- sender ! decorateMessage(Acknowledge)
- executionGraph.scheduleOrUpdateConsumers(partitionId)
+ try {
+ executionGraph.scheduleOrUpdateConsumers(partitionId)
+ sender ! decorateMessage(Acknowledge)
+ } catch {
+ case e: ExecutionGraphException =>
--- End diff --
Does it make sense to catch the more generic `Exception` type here in order
to make the sender notice any problems sooner? I see that the method only
throws EGExceptions currently but maybe at some point in time someone
introduces a runtime exception etc. This would only be logged at the JM and the
task's ask would timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
