[
https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742101#comment-17742101
]
Etienne Chauchot commented on FLINK-32563:
------------------------------------------
[~martijnvisser] I had in mind to be slightly more coercive with connector
authors so that they run CI test on last 2 versions and specify which of the 2
is main supported one (for running archunit but also other things). I was
thinking of something like this (in _testing.yml style):
{code:java}
jobs:
compile_and_test:
strategy:
matrix:
include:
- flink: 1.16.2
main_version: false
- flink: 1.17.1
main_version: true
uses: ./.github/workflows/ci.yml
with:
connector_branch: ci_utils
flink_version: ${{ matrix.flink }}
main_flink_version: ${{ matrix.main_version }}
{code}
{code:java}
inputs:
main_flink_version:
description: "Is the input Flink version, the main version that the
connector supports."
required: false // to avoid break the existing connectors
type: boolean
default: false
{code}
Do you prefer something like this ?
{code:java}
jobs:
enable-archunit-tests:
uses: ./.github/workflows/ci.yml
with:
flink_version: 1.17.1
connector_branch: ci_utils
run_archunit_tests: true
{code}
{code:java}
inputs:
run_archunit_tests:
description: "Whether to run the archunit tests"
required: false // to avoid break the existing connectors
type: boolean
default: false
{code}
> Allow connectors CI to specify the main supported Flink version
> ---------------------------------------------------------------
>
> Key: FLINK-32563
> URL: https://issues.apache.org/jira/browse/FLINK-32563
> Project: Flink
> Issue Type: Technical Debt
> Components: Build System / CI
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
>
> As part of [this
> discussion|https://lists.apache.org/thread/pr0g812olzpgz21d9oodhc46db9jpxo3]
> , the need for connectors to specify the main flink version that a connector
> supports has arisen.
> This CI variable will allow to configure the build and tests differently
> depending on this version. This parameter would be optional.
> The first use case is to run archunit tests only on the main supported
> version as discussed in the above thread.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
