ferenc-csaky commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1261353832
########## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreTest.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.configuration.Configuration; + +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.AssertionsForClassTypes.assertThat; + +/** Test for {@link GenericInMemoryCatalogStore}. */ +public class GenericInMemoryCatalogStoreTest { + + @Test + void testStoreAndGet() { + CatalogStore catalogStore = new GenericInMemoryCatalogStore(); + catalogStore.open(); + + catalogStore.storeCatalog( + "catalog1", CatalogDescriptor.of("catalog1", new Configuration())); + assertThat(catalogStore.getCatalog("catalog1").isPresent()).isTrue(); + assertThat(catalogStore.contains("catalog1")).isTrue(); + + catalogStore.removeCatalog("catalog1", true); + assertThat(catalogStore.contains("catalog1")).isFalse(); + + catalogStore.close(); Review Comment: >We could store an opened or closed flag for it and based on that throw an exception for any access of the catalog store is not yet opened or closed already. By "any access of the catalog store" I meant the catalog store should validate its state and throw an exception if necessary. IMO that means any method that actually touches the content of the catalog store, which is basically true for every method other than the `open()` and `close()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
