1996fanrui commented on code in PR #22761:
URL: https://github.com/apache/flink/pull/22761#discussion_r1263432442
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java:
##########
@@ -65,7 +65,7 @@ public abstract class BufferWritingResultPartition extends
ResultPartition {
private TimerGauge hardBackPressuredTimeMsPerSecond = new TimerGauge();
- private long totalWrittenBytes;
+ protected long totalWrittenBytes;
Review Comment:
Hi @akalash , thanks a lot for your very patient review again.
> I mean we can create addToSubpartition method in
BufferWritingResultPartition and use it everywhere(and maybe it will be better
than now)
I think it will be better than now as well, and this is the only better
solution I can think of right now.
Updated by the last commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
