akalash commented on PR #22761: URL: https://github.com/apache/flink/pull/22761#issuecomment-1635769002
`BufferWritingResultPartition` is performance critical class since it is on the hot path. But your changes mostly touched not so 'hot' things like recovery and I don't think that it will be any degradation. It's why I don't think that you should do benchmarking for this PR but since `BufferWritingResultPartition` was touched anyhow I suggest taking a look at the benchmarks the next day after merging this PR to be 100% sure that it doesn't bring any degradation > BTW, do you think this fix should be backported to 1.17 and 1.16? Good question. Officially we should support the previous version but I'm not fully sure that it makes sense to do it for metrics improvement. So I think it won't be a mistake if you backport it but I think it is also ok if you merge only to master. (we can always backport later if somebody decided that it is worth it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
