WencongLiu commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1264367896
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1251,7 +1253,20 @@ private CompletableFuture<Void> removeJob(JobID jobId,
CleanupJobState cleanupJo
if (cleanupJobState.isGlobalCleanup()) {
return globalResourceCleaner
.cleanupAsync(jobId)
- .thenRunAsync(() -> markJobAsClean(jobId), ioExecutor)
+ .thenRunAsync(
Review Comment:
Fixed.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -1262,14 +1277,8 @@ private CompletableFuture<Void> removeJob(JobID jobId,
CleanupJobState cleanupJo
}
}
- private void markJobAsClean(JobID jobId) {
- try {
- jobResultStore.markResultAsClean(jobId);
- log.debug(
- "Cleanup for the job '{}' has finished. Job has been
marked as clean.", jobId);
- } catch (IOException e) {
- log.warn("Could not properly mark job {} result as clean.", jobId,
e);
- }
+ private CompletableFuture<Void> markJobAsCleanAsync(JobID jobId) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
