lincoln-lil opened a new pull request, #23001:
URL: https://github.com/apache/flink/pull/23001

   ## What is the purpose of the change
   Currently when group by window time columns on a proctime window operator 
result will get a wrong plan which may result hang for ever in runtime(this 
only happens with informally supported forms, all standard forms cascaded 
window aggregation works fine). 
   This is because an incorrectly translation that create an event-time window 
agg operator in such case, but actually there's no corresponding window 
assigner to trigger the window (no local timeservice neither).  For the fix, we 
convert these cases into a normal group aggregate to make it works and doesn't 
break anything.
   
   ## Brief change log
   fix the matching logic of `StreamPhysicalWindowAggregateRule` in proctime 
mode and related path
   
   ## Verifying this change
   adds test cases to verify the plan changes in `WindowAggregateTest`
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
@Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to