reswqa commented on PR #22585: URL: https://github.com/apache/flink/pull/22585#issuecomment-1637408260
> Sorry for not getting back on that one earlier. It doesn't matter. Thanks @XComp for picking this up! > I'm confused by what you mean by "if it's safe enough". 🤔 The results returned may be different between multiple calls to `isInGlobalyTerminalState` (due to an entry may happened to be written to `JobResultStore` in the `ioExecutor`). In the implementation before the change, we can sense the change of this state faster (because multiple calls were made), and after the change, there is only one call. I don't think there should be any problems here, but I'm not very sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
