yuchengxin commented on code in PR #22767:
URL: https://github.com/apache/flink/pull/22767#discussion_r1264960252
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PushWatermarkIntoTableSourceScanRuleBase.java:
##########
@@ -117,8 +126,33 @@ protected FlinkLogicalTableSourceScan getNewScan(
idleTimeoutMillis = -1L;
}
+ Optional<RelHint> optionsHintOptional =
+ scan.getHints().stream()
+ .filter(
+ relHint ->
+ relHint.hintName.equalsIgnoreCase(
+
FlinkHints.HINT_NAME_OPTIONS))
+ .findFirst();
+ Configuration hintOptions = new Configuration();
+ if (optionsHintOptional.isPresent()) {
+ RelHint optionsHint = optionsHintOptional.get();
+ hintOptions = Configuration.fromMap(optionsHint.kvOptions);
+ }
Review Comment:
modified
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/WatermarkPushDownSpec.java:
##########
@@ -104,11 +116,15 @@ public String getDigests(SourceAbilityContext context) {
watermarkExpr,
JavaScalaConversionUtil.toScala(
context.getSourceRowType().getFieldNames()));
+ String digest = String.format("watermark=[%s]", expressionStr);
if (idleTimeoutMillis > 0) {
- return String.format(
- "watermark=[%s], idletimeout=[%d]", expressionStr,
idleTimeoutMillis);
+ digest = String.format("%s, idletimeout=[%d]", digest,
idleTimeoutMillis);
+ }
+ if (watermarkParams != null) {
+ WatermarkEmitStrategy emitStrategy =
watermarkParams.getEmitStrategy();
+ digest = String.format("%s, watermarkEmitStrategy=[%s]", digest,
emitStrategy);
}
- return String.format("watermark=[%s]", expressionStr);
+ return digest;
Review Comment:
modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
