zentol commented on PR #23003: URL: https://github.com/apache/flink/pull/23003#issuecomment-1638249915
> I notice that change the relocate pattern may not fix the real class not found issue, > It seems without this new shade pattern tests always failed. I'd love to get a summary of what works and what doesn't with what changes to the shade-plugin / ci-tools; I can't wrap my head around the current state. The PR description states that the original PR failed with a CNFE for a relocated netty class, using the original pulsar relocation. You then tried to change the relocation pattern (why?), which required changes to ci-tools; what's still unclear to me is whether it fixed the issue or not. If some class is missing from pulsar then another round of relocations shouldn't make a difference _unless_ you also bundle another netty version and relocate that as well. Double-check whether the final jar actually contains the relocated netty. In fact, double-check that the original pulsar jars actually contain the relocated netty. Let's make sure we aren't trying to build on a rotten foundation here (== packaging issues on the pulsar side). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
