dannycranmer commented on code in PR #22901:
URL: https://github.com/apache/flink/pull/22901#discussion_r1265480710
##########
docs/layouts/shortcodes/generated/expert_rest_section.html:
##########
@@ -20,6 +20,18 @@
<td>Long</td>
<td>The time in ms that the client waits for the leader address,
e.g., Dispatcher or WebMonitorEndpoint</td>
</tr>
+ <tr>
+ <td><h5>rest.cache.checkpoint-statistics.size</h5></td>
+ <td style="word-wrap: break-word;">1000</td>
+ <td>Integer</td>
+ <td>Maximum number of entries in the checkpoint statistics
cache.</td>
+ </tr>
+ <tr>
+ <td><h5>rest.cache.checkpoint-statistics.timeout</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Duration</td>
+ <td>Duration from write after which cached checkpoints statistics
are cleaned up. For backwards compatibility, if this is not specified, the
web.refresh-interval will be used instead.</td>
Review Comment:
Can we elaborate the default in the "Default" column rather than putting
`none` ?
##########
docs/layouts/shortcodes/generated/expert_rest_section.html:
##########
@@ -20,6 +20,18 @@
<td>Long</td>
<td>The time in ms that the client waits for the leader address,
e.g., Dispatcher or WebMonitorEndpoint</td>
</tr>
+ <tr>
+ <td><h5>rest.cache.checkpoint-statistics.size</h5></td>
Review Comment:
Cn you justify why this config should go into the `rest.*` bucket and not
the `web.*` bucket? Seems llike we have similar configs in the `web.*` section,
for example `web.exception-history-size`
##########
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java:
##########
@@ -193,6 +193,24 @@ public class RestOptions {
+ "Lowering the thread priority will give
Flink's main components more CPU time whereas "
+ "increasing will allocate more time for
the REST server's processing.");
+ /** Duration from write, after which cached checkpoints statistics are
cleaned up. */
+ @Documentation.Section(Documentation.Sections.EXPERT_REST)
+ public static final ConfigOption<Duration>
CACHE_CHECKPOINT_STATISTICS_TIMEOUT =
+ key("rest.cache.checkpoint-statistics.timeout")
+ .durationType()
+ .noDefaultValue()
Review Comment:
Same comment as the docs, this does have a default value..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
