wanglijie95 commented on code in PR #22861:
URL: https://github.com/apache/flink/pull/22861#discussion_r1266446464
##########
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java:
##########
@@ -234,10 +235,14 @@ public AllocationID getAllocationId() {
*
* @param blobService the blob store to use (may be <tt>null</tt> if {@link
* #serializedJobInformation} and {@link #serializedTaskInformation}
are non-<tt>null</tt>)
+ * @param shuffleDescriptorsCache cache of shuffle descriptors to reduce
the cost of
+ * deserialization
* @throws IOException during errors retrieving or reading the BLOBs
* @throws ClassNotFoundException Class of a serialized object cannot be
found.
*/
- public void loadBigData(@Nullable PermanentBlobService blobService)
+ public void loadBigDataAndDeserializeShuffleDescriptors(
Review Comment:
I personlly think that we keep the original name `loadBigData` is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
