yunfengzhou-hub commented on code in PR #22931:
URL: https://github.com/apache/flink/pull/22931#discussion_r1267876016
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -2079,11 +2149,19 @@ private final class ScheduledTrigger implements
Runnable {
@Override
public void run() {
+ long currentTime = clock.relativeTimeMillis();
+ if (lastCheckpointTriggeringRelativeTime != NO_CHECKPOINT
+ && currentTime - lastCheckpointTriggeringRelativeTime <
baseInterval) {
+ return;
+ }
+ lastCheckpointTriggeringRelativeTime = currentTime;
+
try {
triggerCheckpoint(checkpointProperties, null, true);
} catch (Exception e) {
LOG.error("Exception while triggering checkpoint for job {}.",
job, e);
}
+ timer.schedule(this, baseInterval, TimeUnit.MILLISECONDS);
Review Comment:
I'm not sure I understand the expected behavior clearly. The current
implementation ensures that the next checkpoint will be <= T2+ X, depending on
the random init delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
