[GitHub] [flink] lsyldliu commented on a diff in pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

Wed, 19 Jul 2023 09:02:03 -0700 


lsyldliu commented on code in PR #23012:
URL: https://github.com/apache/flink/pull/23012#discussion_r1268292637


##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowDataSerDeSchemaTest.java:
##########
@@ -724,7 +786,7 @@ private void testParseErrors(TestSpec spec) {
                     TestSpec.json("{\"id\":\"abc\"}")
                             .rowType(ROW(FIELD("id", INT())))
                             .expectErrorMessage("Failed to deserialize JSON 
'{\"id\":\"abc\"}'."),
-                    TestSpec.json("{\"id\":112.013}")
+                    TestSpec.json("{\"id\":112}")

Review Comment:
   Yes, the `JsonParser` can't parse double type to bigint.
   `JsonParser` logic:
   
![image](https://github.com/apache/flink/assets/17698589/112771b9-380d-46d6-bc77-3278db6526ed)
   
   `JsonNode` logic:
   
![image](https://github.com/apache/flink/assets/17698589/19b1a839-6863-440b-95de-74b2ccd3baf0)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to