[ 
https://issues.apache.org/jira/browse/FLINK-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622072#comment-15622072
 ] 

ASF GitHub Bot commented on FLINK-4935:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2714#discussion_r85732479
  
    --- Diff: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandlerTest.java
 ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.webmonitor.handlers;
    +
    +import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
    +import 
org.apache.flink.runtime.webmonitor.handlers.JarActionHandler.JarActionHandlerConfig;
    +import org.junit.Test;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +public class JarActionHandlerTest {
    +
    +   /**
    +    * Test that the savepoint settings are correctly parsed.
    +    */
    +   @Test
    +   public void testSavepointRestoreSettings() throws Exception {
    +           Map<String, String> pathParams = new HashMap<>();
    +           pathParams.put("jarid", "required"); // required
    +           pathParams.put("savepointPath", "ignored"); // should be ignored
    --- End diff --
    
    it says it should be ignored, but now why.


> Submit job with savepoint via REST API
> --------------------------------------
>
>                 Key: FLINK-4935
>                 URL: https://issues.apache.org/jira/browse/FLINK-4935
>             Project: Flink
>          Issue Type: Improvement
>          Components: Web Client
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> Add an option to REST API allowing to submit JARs with custom savepoint 
> restore settings. Currently, you cannot restore from a savepoint when using 
> the REST API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to