LadyForest commented on code in PR #23033:
URL: https://github.com/apache/flink/pull/23033#discussion_r1270179905
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/sources/tsextractors/ExistingField.java:
##########
@@ -42,7 +42,12 @@
/**
* Converts an existing {@link Long}, {@link java.sql.Timestamp}, or timestamp
formatted
* java.lang.String field (e.g., "2018-05-28 12:34:56.000") into a rowtime
attribute.
+ *
+ * @deprecated This class will not be supported in the new source design
around {@link
+ * org.apache.flink.table.connector.source.DynamicTableSource}. See
FLIP-95 for more
+ * information.
*/
+@Deprecated
@PublicEvolving
public final class ExistingField extends TimestampExtractor {
Review Comment:
Hi @JingGe, thanks for your reminder.
> Does it make sense to do it within this PR?
I think we can open a dedicated task to migrate the E2E test to the new
design since except for `ExistingField`, `StreamSQLTestProgram` also refers to
some already deprecated APIs like `StreamTableSource`,
`DefinedRowtimeAttributes`, `DefinedFieldMapping`, and `TableSchema` etc.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
