[
https://issues.apache.org/jira/browse/FLINK-32560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746312#comment-17746312
]
Xintong Song commented on FLINK-32560:
--------------------------------------
[~twalthr],
Crossposting your comment here in order to keep the discussions at one place.
{quote}TBH I'm questioning this PR. We only deprecated the entry points to the
API because we wanted to keep the API usable while it still exists. Nobody
wants to develop in an API where every single method is deprecated. I'm fine
maybe with class-level deprecations if we need more of those. But spamming the
codebase with deprecations while everyones knows that the entire API will be
removed, is not very helpful. It will also spam CI/CD logs with hundreds of
warnings.
{quote}
I see your point, but I tend to think this differently. Technically speaking,
yes, by deprecating the entry points we implicitly send the message that all
Scala APIs are deprecated. However, that requires users to carefully read the
deprecation message, which many of the users don't from my experience. IMHO,
trying to catch the attention of the careless users is probably more important
than not disturbing the users who insists to work with the deprecated Scala API.
{quote}I'm fine maybe with class-level deprecations if we need more of those.
{quote}
+1. There are many methods annotated because they have different API stability
from the containing class. E.g., the class is annotated as `@Public` while some
of its methods are annotated as `@PublicEvolving`. For such methods, I think
it's good enough to mark deprecation at the class level.
> Properly deprecate all Scala APIs
> ---------------------------------
>
> Key: FLINK-32560
> URL: https://issues.apache.org/jira/browse/FLINK-32560
> Project: Flink
> Issue Type: Sub-task
> Components: API / Scala
> Reporter: Xintong Song
> Assignee: Ryan Skraba
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.18.0
>
>
> We agreed to drop Scala API support in FLIP-265 [1], and have tried to
> deprecate them in FLINK-29740. Also, both user documentation and roadmap[2]
> shows that scala API supports are deprecated. However, none of the APIs in
> `flink-streaming-scala` are annotated with `@Deprecated` atm, and only
> `ExecutionEnvironment` and `package` are marked `@Deprecated` in
> `flink-scala`.
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-265+Deprecate+and+remove+Scala+API+support
> [2] https://flink.apache.org/roadmap/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
