XComp commented on code in PR #22987:
URL: https://github.com/apache/flink/pull/22987#discussion_r1271900214
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##########
@@ -289,6 +298,16 @@ private CompletableFuture<Void> shutdownInternally(Time
timeout) {
return terminationFuture;
}
+ private void notifyResponseFuturesOfShutdown() {
+ responseChannelFutures
+ .keySet()
+ .forEach(
+ future ->
+ future.completeExceptionally(
+ new IOException("RestClient is
closed")));
Review Comment:
```suggestion
new IOException("RestClient was
closed while processing the request.")));
```
proposal in contrast to the `IOException` error message I proposed in [the
related comment
above](https://github.com/apache/flink/pull/22987#discussion_r1271898836).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
