1996fanrui commented on code in PR #23059:
URL: https://github.com/apache/flink/pull/23059#discussion_r1272939403
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/coordination/RecreateOnResetOperatorCoordinatorTest.java:
##########
@@ -264,6 +264,19 @@ public void testConsecutiveResetToCheckpoint() throws
Exception {
"Timed out when waiting for the coordinator to close.");
}
+ @Test
+ public void testNotifyCheckpointAbortedSuccess() throws Exception {
+ TestingCoordinatorProvider provider = new
TestingCoordinatorProvider(null);
+ MockOperatorCoordinatorContext context =
+ new MockOperatorCoordinatorContext(OPERATOR_ID, NUM_SUBTASKS);
+ RecreateOnResetOperatorCoordinator coordinator =
createCoordinator(provider, context);
+ TestingOperatorCoordinator internalCoordinatorAfterReset =
+ getInternalCoordinator(coordinator);
+
+ coordinator.notifyCheckpointAborted(1L);
+
assertThat(internalCoordinatorAfterReset.getLastCheckpointAborted()).isEqualTo(1L);
Review Comment:
@liming30 , thanks for the update, I left a minor comment.
nits:
```suggestion
long checkpointId = 10L;
coordinator.notifyCheckpointAborted(checkpointId);
assertThat(internalCoordinatorAfterReset.getLastCheckpointAborted()).isEqualTo(checkpointId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
