[ 
https://issues.apache.org/jira/browse/FLINK-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622452#comment-15622452
 ] 

ASF GitHub Bot commented on FLINK-4315:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2637#discussion_r85761498
  
    --- Diff: 
flink-batch-connectors/flink-hadoop-compatibility/src/main/scala/org/apache/flink/api/scala/hadoop/FlinkHadoopEnvironment.scala
 ---
    @@ -0,0 +1,165 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.scala.hadoop
    +
    +import org.apache.flink.annotation.{Public, PublicEvolving}
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.scala.hadoop.mapred.{HadoopInputFormat => 
MapredHadoopInputFormat}
    +import org.apache.flink.api.scala.hadoop.mapreduce.{HadoopInputFormat => 
MapreduceHadoopInputFormat}
    +import org.apache.flink.api.scala.{DataSet, ExecutionEnvironment}
    +import org.apache.hadoop.fs.{Path => HadoopPath}
    +import org.apache.hadoop.mapred.{JobConf, FileInputFormat => 
MapredFileInputFormat, InputFormat => MapredInputFormat}
    +import org.apache.hadoop.mapreduce.lib.input.{FileInputFormat => 
MapreduceFileInputFormat}
    +import org.apache.hadoop.mapreduce.{Job, InputFormat => 
MapreduceInputFormat}
    +
    +/**
    + * The FlinkHadoopEnvironment is the context in which a program is 
executed, connected with hadoop.
    + *
    + * The environment provides methods to interact with the hadoop cluster 
(data access).
    + *
    + *  Use [[FlinkHadoopEnvironment#getHadoopEnvironment]] to get the correct 
environment.
    + */
    +@Public
    +class FlinkHadoopEnvironment(parentEnv: ExecutionEnvironment) {
    --- End diff --
    
    Can you convert the Scala code into a `HadoopInputs` as well?


> Deprecate Hadoop dependent methods in flink-java
> ------------------------------------------------
>
>                 Key: FLINK-4315
>                 URL: https://issues.apache.org/jira/browse/FLINK-4315
>             Project: Flink
>          Issue Type: Task
>          Components: Java API
>            Reporter: Stephan Ewen
>            Assignee: Evgeny Kincharov
>             Fix For: 2.0.0
>
>
> The API projects should be independent of Hadoop, because Hadoop is not an 
> integral part of the Flink stack, and we should have the option to offer 
> Flink without Hadoop dependencies.
> The current batch APIs have a hard dependency on Hadoop, mainly because the 
> API has utility methods like `readHadoopFile(...)`.
> I suggest to deprecate those methods and add helpers in the 
> `flink-hadoop-compatibility` project.
> FLINK-4048 will later remove the deprecated methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to