chenyuzhi459 commented on PR #23053: URL: https://github.com/apache/flink/pull/23053#issuecomment-1649248906
> Just use a linked hashmap in `metricIsRemovedWhileOtherMetricsWithSameNameExist` instead of modifying production code There's no requirement for the prod code to actually sort dimensions. Well, thanks for your your tips! Following your approach does solve the unit testing problem. However, I have a bit of a problem with the fact that the input parameter variables to the method doesn't seem to be guaranteed to be a linked hashmap, but rather a hashmap. I am happy to follow your suggestions to optimize unit tests, but it would be very grateful if I can get your clarification on the above problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
