Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2637#discussion_r85764470
  
    --- Diff: 
flink-batch-connectors/flink-hadoop-compatibility/src/main/java/org/apache/flink/hadoopcompatibility/HadoopInputs.java
 ---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.hadoopcompatibility;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.java.hadoop.mapred.HadoopInputFormat;
    +import org.apache.hadoop.mapred.JobConf;
    +import org.apache.hadoop.mapreduce.Job;
    +
    +import java.io.IOException;
    +
    +/**
    + * The HadoopInputs is the utility class for create {@link 
HadoopInputFormat}.
    --- End diff --
    
    I would make the purpose of the class a bit more explicit.
    
    > HadoopInputs is a utility class to use Apache Hadoop InputFormats with 
Apache Flink.
    
    > It provides methods to create Flink `InputFormat` wrappers for Hadoop 
`org.apache.hadoop.mapred.InputFormat` and 
`org.apache.hadoop.mapreduce.InputFormat`.
    > Key value pairs produced by the Hadoop InputFormats are converted into 
Flink Tuple2 objects where the first field (`Tuple2.f0`) is the key and the 
second field (`Tuple2.f1`) is the value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to