lincoln-lil commented on code in PR #23075:
URL: https://github.com/apache/flink/pull/23075#discussion_r1274930002
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
+this user specified target column list can be found from the {{< gh_link
file="flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java"
name="DynamicTableSink$Context.getTargetColumns()" >}}.
Review Comment:
if the above new version is ok, then this dash will not be added
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
How about: "For connector developers who want to avoid overwriting
non-target columns with null values when processing partial column updates, you
can get the information about the target columns specified by the user's insert
statement from 'getTargetColumns(link...)' and decide how to process the
partial updates."
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
current version:
a new line seems to be better, will update it.
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
The corresponding chinese version: 连接器开发人员在处理部分列更新时，如果希望避免用空值覆盖非目标列，可以从
"getTargetColumns(link...) "中获取用户插入语句指定的目标列信息，然后决定如何处理部分更新。
##########
docs/content/docs/dev/table/sql/insert.md:
##########
@@ -208,7 +208,9 @@ column_list:
**COLUMN LIST**
Given a table T(a INT, b INT, c INT), Flink supports INSERT INTO T(c, b)
SELECT x, y FROM S. The expectation is
-that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+that 'x' is written to column 'c' and 'y' is written to column 'b' and 'a' is
set to NULL (assuming column 'a' is nullable).
+For the connector developers who want to avoid overwriting non-target columns
with null values when processing partial column updates,
Review Comment:
The corresponding chinese version: 连接器开发人员在处理部分列更新时，如果希望避免用空值覆盖非目标列，可以从
"getTargetColumns(link...) "中获取用户插入语句指定的目标列信息，然后决定如何处理部分更新。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
