lindong28 commented on code in PR #23021:
URL: https://github.com/apache/flink/pull/23021#discussion_r1275633566
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java:
##########
@@ -103,56 +106,63 @@ protected Transformation<RowData> translateToPlanInternal(
final ScanTableSource tableSource =
tableSourceSpec.getScanTableSource(
planner.getFlinkContext(),
ShortcutUtils.unwrapTypeFactory(planner));
+ final String sourceInfo =
+
tableSourceSpec.getContextResolvedTable().getIdentifier().asSummaryString();
Review Comment:
For those tableSourceSpec that points to the same source, will they have the
same `ScanTableSource.ScanRuntimeProvider provider` instance?
If yes, instead of adding an extra interface `WithSourceInfo` to maintain
the source table identifier in selected Transformation subclass, would it be
more intuitive to have the same instance of `ScanRuntimeProvider` always return
the same Transformation, similar to what is done for
`TransformationScanProvider`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
