MartijnVisser commented on code in PR #23087:
URL: https://github.com/apache/flink/pull/23087#discussion_r1280458306
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvToRowDataConverters.java:
##########
@@ -185,48 +187,57 @@ private CsvToRowDataConverter createConverter(LogicalType
type) {
}
}
- private boolean convertToBoolean(JsonNode jsonNode) {
+ private <V> V convertStringToValue(JsonNode jsonNode, Function<String, V>
function) {
Review Comment:
> and go for 2 finally, maybe in Flink 2.0?
Do propose it for Flink 2.0 indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
