XComp commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1282185399


##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractThreadsafeJobResultStore.java:
##########


Review Comment:
   Maybe it helps to compare your approach with the [proposal 
above](https://github.com/apache/flink/pull/22341#discussion_r1282183101) to 
get a better understanding of the `CompletableFuture` usage. Feel free to ask 
questions about it. And don't hesitate to question my approach! See it as a 
discussion item. :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to