WencongLiu commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1282979301
##########
flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java:
##########
@@ -381,9 +381,12 @@ public static void rethrowException(Throwable t) throws
Exception {
* @param e exception to throw if not null.
* @throws Exception
*/
- public static void tryRethrowException(@Nullable Exception e) throws
Exception {
+ public static void tryRethrowException(@Nullable Throwable e) throws
Exception {
Review Comment:
If the `throws Exception` is modified to `throws Throwable`, many classes
that use the tryRethrowException have to `throws Throwable` 🤔 I'd prefer to
refactor this in the old way and keep it in a separate hotfix commit. WDYT?
##########
flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java:
##########
@@ -381,9 +381,12 @@ public static void rethrowException(Throwable t) throws
Exception {
* @param e exception to throw if not null.
* @throws Exception
*/
- public static void tryRethrowException(@Nullable Exception e) throws
Exception {
+ public static void tryRethrowException(@Nullable Throwable e) throws
Exception {
Review Comment:
If the `throws Exception` is modified to `throws Throwable`, many classes
that use the tryRethrowException have to `throws Throwable` 🤔 I'd prefer to
refactor this in the old way and keep it in a separate hotfix commit. WDYT?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/runner/JobDispatcherLeaderProcessFactoryFactory.java:
##########
@@ -77,7 +77,14 @@ public JobDispatcherLeaderProcessFactory createFactory(
}
final JobResultStore jobResultStore =
jobPersistenceComponentFactory.createJobResultStore();
- final Collection<JobResult> recoveredDirtyJobResults =
getDirtyJobResults(jobResultStore);
+ final Collection<JobResult> recoveredDirtyJobResults;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
