WencongLiu commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1283910488
##########
flink-examples/flink-examples-batch/pom.xml:
##########
@@ -48,25 +48,6 @@ under the License.
<build>
<plugins>
- <!-- Fail compilation on deprecation warnings to
prevent from showing users outdated examples. -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- <executions>
- <execution>
- <id>compile</id>
- <phase>process-sources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- <configuration>
-
<compilerArgument>-Xlint:deprecation</compilerArgument>
-
<failOnWarning>true</failOnWarning>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
Review Comment:
Fixed.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* <p>The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741";>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API</a>
*/
+ @Deprecated
Review Comment:
Fixed.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -913,6 +920,18 @@ public LinkedHashSet<Class<?>> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+ /**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and
will be removed in a
+ * future Flink major version. You can still build your application in
DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741";>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API</a>
+ */
+ @Deprecated
Review Comment:
Fixed.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -544,6 +544,13 @@ public ExecutionConfig setExecutionRetryDelay(long
executionRetryDelay) {
* <p>The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @param executionMode The execution mode to use.
+ * @deprecated The {@link ExecutionMode} is deprecated because it's only
used in DataSet APIs.
+ * All Flink DataSet APIs are deprecated since Flink 1.18 and will be
removed in a future
+ * Flink major version. You can still build your application in
DataSet, but you should move
+ * to either the DataStream and/or Table API.
+ * @see <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741";>
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and
deprecate the DataSet
+ * API</a>
*/
public void setExecutionMode(ExecutionMode executionMode) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
