WencongLiu commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1284120242
##########
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestingJobResultStore.java:
##########
@@ -116,58 +111,53 @@ public static TestingJobResultStore.Builder builder() {
/** {@code Builder} for instantiating {@code TestingJobResultStore}
instances. */
public static class Builder {
- private ThrowingConsumer<JobResultEntry, ? extends IOException>
createDirtyResultConsumer =
- ignored -> {};
- private ThrowingConsumer<JobID, ? extends IOException>
markResultAsCleanConsumer =
- ignored -> {};
+ private Function<JobResultEntry, CompletableFuture<Void>>
createDirtyResultConsumer =
+ jobResultEntry -> CompletableFuture.completedFuture(null);
+ private Function<JobID, CompletableFuture<Void>>
markResultAsCleanConsumer =
+ jobID -> CompletableFuture.completedFuture(null);
- private FunctionWithException<JobID, Boolean, ? extends IOException>
- hasJobResultEntryFunction = ignored -> false;
- private FunctionWithException<JobID, Boolean, ? extends IOException>
- hasDirtyJobResultEntryFunction = ignored -> false;
- private FunctionWithException<JobID, Boolean, ? extends IOException>
- hasCleanJobResultEntryFunction = ignored -> false;
+ private Function<JobID, CompletableFuture<Boolean>>
hasJobResultEntryFunction =
+ jobID -> CompletableFuture.completedFuture(false);
+ private Function<JobID, CompletableFuture<Boolean>>
hasDirtyJobResultEntryFunction =
+ jobID -> CompletableFuture.completedFuture(false);
+ private Function<JobID, CompletableFuture<Boolean>>
hasCleanJobResultEntryFunction =
+ jobID -> CompletableFuture.completedFuture(false);
- private SupplierWithException<Set<JobResult>, ? extends IOException>
- getDirtyResultsSupplier = Collections::emptySet;
+ private Supplier<Set<JobResult>> dirtyResultsSupplier =
Collections::emptySet;
public Builder withCreateDirtyResultConsumer(
- ThrowingConsumer<JobResultEntry, ? extends IOException>
createDirtyResultConsumer) {
+ Function<JobResultEntry, CompletableFuture<Void>>
createDirtyResultConsumer) {
this.createDirtyResultConsumer = createDirtyResultConsumer;
return this;
}
public Builder withMarkResultAsCleanConsumer(
- ThrowingConsumer<JobID, ? extends IOException>
markResultAsCleanConsumer) {
+ Function<JobID, CompletableFuture<Void>>
markResultAsCleanConsumer) {
this.markResultAsCleanConsumer = markResultAsCleanConsumer;
return this;
}
public Builder withHasJobResultEntryFunction(
- FunctionWithException<JobID, Boolean, ? extends IOException>
- hasJobResultEntryFunction) {
+ Function<JobID, CompletableFuture<Boolean>>
hasJobResultEntryFunction) {
this.hasJobResultEntryFunction = hasJobResultEntryFunction;
return this;
}
public Builder withHasDirtyJobResultEntryFunction(
- FunctionWithException<JobID, Boolean, ? extends IOException>
- hasDirtyJobResultEntryFunction) {
+ Function<JobID, CompletableFuture<Boolean>>
hasDirtyJobResultEntryFunction) {
this.hasDirtyJobResultEntryFunction =
hasDirtyJobResultEntryFunction;
return this;
}
public Builder withHasCleanJobResultEntryFunction(
- FunctionWithException<JobID, Boolean, ? extends IOException>
- hasCleanJobResultEntryFunction) {
+ Function<JobID, CompletableFuture<Boolean>>
hasCleanJobResultEntryFunction) {
this.hasCleanJobResultEntryFunction =
hasCleanJobResultEntryFunction;
return this;
}
public Builder withGetDirtyResultsSupplier(
- SupplierWithException<Set<JobResult>, ? extends IOException>
- getDirtyResultsSupplier) {
- this.getDirtyResultsSupplier = getDirtyResultsSupplier;
+ Supplier<Set<JobResult>> getDirtyResultsSupplier) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
