Samrat002 commented on code in PR #21458:
URL: https://github.com/apache/flink/pull/21458#discussion_r1284570168
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -126,7 +126,9 @@ public long getPos() throws IOException {
@Override
public void sync() throws IOException {
- fileStream.sync();
+ // for s3 there is no sync supported.
+ // instead calling persist() to put data into s3.
+ persist();
}
Review Comment:
Added test and validated manually in EMR cluster via writing Csv data in s3
of (10Gb and 70GB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
