[
https://issues.apache.org/jira/browse/FLINK-32761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feifan Wang updated FLINK-32761:
--------------------------------
Description:
_ChangelogStateHandleStreamImpl#getKey()_ use
_System.identityHashCode(stateHandle)_ as _SharedStateRegistryKey_ while
stateHandle is not _FileStateHandle_ or {_}ByteStreamStateHandle{_}. That can
easily lead to collision, although from the current code path, it only affects
the test code.
In FLINK-29913 , we use md5 sum of PhysicalStateHandleID as
SharedStateRegistryKey in IncrementalRemoteKeyedStateHandle, we can reuse this
method in ChangelogStateHandleStreamImpl.
WDYT [~roman] ?
was:
_ChangelogStateHandleStreamImpl#getKey()_ use
_System.identityHashCode(stateHandle)_ as _SharedStateRegistryKey_ while
stateHandle is not _FileStateHandle_ or {_}ByteStreamStateHandle{_}. That can
easily lead to collision, although from the current code path, it only affects
the test code.
In FLINK-29913 , we use md5 sum of PhysicalStateHandleID as
SharedStateRegistryKey in IncrementalRemoteKeyedStateHandle, we can reuse this
method in ChangelogStateHandleStreamImpl.
> Use md5 sum of PhysicalStateHandleID as SharedStateRegistryKey
> ChangelogStateHandleStreamImpl
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-32761
> URL: https://issues.apache.org/jira/browse/FLINK-32761
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Reporter: Feifan Wang
> Priority: Major
>
> _ChangelogStateHandleStreamImpl#getKey()_ use
> _System.identityHashCode(stateHandle)_ as _SharedStateRegistryKey_ while
> stateHandle is not _FileStateHandle_ or {_}ByteStreamStateHandle{_}. That can
> easily lead to collision, although from the current code path, it only
> affects the test code.
> In FLINK-29913 , we use md5 sum of PhysicalStateHandleID as
> SharedStateRegistryKey in IncrementalRemoteKeyedStateHandle, we can reuse
> this method in ChangelogStateHandleStreamImpl.
>
> WDYT [~roman] ?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
