ferenc-csaky commented on code in PR #23108:
URL: https://github.com/apache/flink/pull/23108#discussion_r1285662789
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java:
##########
@@ -1193,4 +1194,70 @@ private Stream<TestSetSpec> arraySliceTestCases() {
" No match found for function signature
ARRAY_SLICE()")
.testSqlValidationError("ARRAY_SLICE(null)", "Illegal
use of 'NULL'"));
}
+
+ private Stream<TestSetSpec> splitTestCases() {
+ return Stream.of(
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.SPLIT)
+ .onFieldsWithData("123,123,23", null, ",123,123",
",123,123,", 123, "12345")
Review Comment:
I would use `,123,,123,` instead of `,123,123,` so there is a test case for
contiguous delimiters as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
