XComp commented on PR #23136: URL: https://github.com/apache/flink/pull/23136#issuecomment-1667796125
@xuzifu666 Thanks for the PR. But I'm wondering where you see the risk of leaking resources in the test methods you touched. It looks like you only touched code segments where the reader/writer was actually closed through a `close()` call. In the end, you replaced those close calls with `try` blocks (which do the same thing: calling `close()` on the `AutoCloseable` instance). Or do I overlook something? :thinking: If not, I would tend to close this PR without merging. It doesn't bring any new value but might make it harder to backport code changes (due to the difference between `master` and the release branches). I'm curious what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
