swuferhong commented on code in PR #20822:
URL: https://github.com/apache/flink/pull/20822#discussion_r1286646255
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/schema/IntermediateRelTable.scala:
##########
@@ -54,4 +55,19 @@ class IntermediateRelTable(
def this(names: JList[String], relNode: RelNode) {
this(names, relNode, ModifyKindSet.INSERT_ONLY, false, new
util.HashSet[ImmutableBitSet]())
}
+
+ override def getCollationList: util.List[RelCollation] = {
+ val mq = relNode.getCluster.getMetadataQuery
+ mq.collations(relNode)
+ }
+
+ override def getDistribution: RelDistribution = {
+ val fmq =
FlinkRelMetadataQuery.reuseOrCreate(relNode.getCluster.getMetadataQuery)
Review Comment:
> Why don't use
>
> ```
> val fmq = relNode.getCluster.getMetadataQuery
> fmq.distribution(relNode)
> ```
The implementation of FlinkDistribution and Calcite Distribution is
different, and theoretically they need to be the same. I can create another PR
to unify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
