luoyuxia commented on code in PR #23155:
URL: https://github.com/apache/flink/pull/23155#discussion_r1287078208
##########
flink-end-to-end-tests/flink-sql-gateway-test/src/test/java/org/apache/flink/table/gateway/containers/HiveContainer.java:
##########
@@ -47,7 +64,44 @@ protected void doStart() {
}
}
+ @Override
+ protected void finished(Description description) {
+ backupLogs();
+ super.finished(description);
+ }
+
public String getHiveMetastoreURI() {
return String.format("thrift://%s:%s", getHost(),
getMappedPort(HIVE_METASTORE_PORT));
}
+
+ private void backupLogs() {
+ Path path = DISTRIBUTION_LOG_BACKUP_DIRECTORY.get().orElse(null);
Review Comment:
Will it make sense to add a warning log just like
[LocalStandaloneFlinkResourceFactory](https://github.com/apache/flink/blob/28d94e826e4c2a0444fda8103641eb1c64a2223f/flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResourceFactory.java#L43)
does ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
