[ 
https://issues.apache.org/jira/browse/FLINK-32820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752566#comment-17752566
 ] 

Xintong Song commented on FLINK-32820:
--------------------------------------

[~Zhanghao Chen], thanks for reporting this. I wasn't aware that ParameterTool 
is mentioned in documentation.

ParameterTool is currently in the flink-java module, which is likely removed 
together with DataSet API in future. That's why we tried to deprecate it. And 
because many DataStream examples and end-to-ends tests are still depending on 
it, we introduced the other ParameterTool in flink-exmaples-streaming, in a 
different package to avoid conflicts.

If should not be removed, it needs to be moved to another module (maybe 
flink-streaming-java / flink-core), probably in the same package so users need 
not to re-import it as long as the module is included as dependency. However, 
moving it to another module may introduce breaking changes to DataSet users, 
thus should only happen in the major version bump.

So I guess for now reverting the ParameterTool related changes from FLINK-32558 
should be good enough.

> ParameterTool is mistakenly marked as deprecated
> ------------------------------------------------
>
>                 Key: FLINK-32820
>                 URL: https://issues.apache.org/jira/browse/FLINK-32820
>             Project: Flink
>          Issue Type: Bug
>          Components: API / DataSet, API / DataStream
>    Affects Versions: 1.18.0
>            Reporter: Zhanghao Chen
>            Priority: Major
>
> ParameterTool and AbstractParameterTool in pacakge flink-java is mistakenly 
> marked as deprecated in [FLINK-32558] Properly deprecate DataSet API - ASF 
> JIRA (apache.org). They are widely used for handling application parameters 
> and is also listed in the Flink user doc: 
> [https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/application_parameters/.|https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/application_parameters/]
>  Also, they are not directly related to Dataset API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to