lsyldliu commented on code in PR #23058:
URL: https://github.com/apache/flink/pull/23058#discussion_r1289501467
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java:
##########
@@ -96,7 +96,7 @@ public AbstractRowTimeUnboundedPrecedingOver(
}
@Override
- public void open(Configuration parameters) throws Exception {
+ public void open(OpenContext openContext) throws Exception {
Review Comment:
The following class in table module also needs to change, I think you should
check more classes in table.
`ProcTimeRangeBoundedPrecedingFunction`
`RowTimeRangeBoundedPrecedingFunction`
`ProcTimeUnboundedPrecedingFunction`
`ProcTimeRowsBoundedPrecedingFunction`
`RowTimeRowsBoundedPrecedingFunction`
`DeduplicateFunctionBase`
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java:
##########
@@ -96,7 +96,7 @@ public AbstractRowTimeUnboundedPrecedingOver(
}
@Override
- public void open(Configuration parameters) throws Exception {
+ public void open(OpenContext openContext) throws Exception {
Review Comment:
In addition,
https://github.com/apache/flink/blob/6806f30fe234790f25b5ca83e6d2910286a76aeb/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/FunctionCodeGenerator.scala#L220
The codegen function also need to refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
