huwh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1289638320
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,10 @@ public static SubtaskExecutionAttemptDetailsInfo create(
final long now = System.currentTimeMillis();
final TaskManagerLocation location =
execution.getAssignedResourceLocation();
- final String locationString = location == null ? "(unassigned)" :
location.getHostname();
+ final String locationString =
Review Comment:
I've found that the API handles location in different ways, such as
JobExceptionsHandler,JobVertexTaskManagersHandler, they connect the hostname
and data port.
But for
SubtasksAllAccumulatorsHandler,SubtasksTimesHandler,SubtaskExecutionAttemptDetailsInfo,
they only use the hostname.
I think it's better to align these behaviors. We can extract the logic of
the concat of hostname and port to a method of TaskManagerLocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
