venkata91 commented on code in PR #23164:
URL: https://github.com/apache/flink/pull/23164#discussion_r1290511734
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java:
##########
@@ -360,6 +361,17 @@ List<String> registerProvidedLocalResources() {
envShipResourceList.add(descriptor);
if (!isFlinkDistJar(filePath.getName()) &&
!isPlugin(filePath)) {
+ URI parentDirectoryUri = new
Path(fileName).getParent().toUri();
+ String relativeParentDirectory =
+ new Path(filePath.getName())
+ .toUri()
+ .relativize(parentDirectoryUri)
+ .toString();
+
+ if
(!addedParentDirectories.contains(relativeParentDirectory)) {
+ classPaths.add(relativeParentDirectory);
Review Comment:
I think we should follow similar convention as that of
[here](https://github.com/apache/flink/blob/3cd0bf0a67016fe9c0b9ddbf033391ddb87ea496/flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java#L304)?
Here, `resource` directories are added first and also the classpath is sorted
to make it deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
