AdrianVasiliu commented on PR #650: URL: https://github.com/apache/flink-kubernetes-operator/pull/650#issuecomment-1674452121
@gyfora > We don't need to backport this, examples would work across versions. Users can simply use from main I do think this would be fine in the vast majority of cases, for the time being. However: * The sample in master builds with flink 1.17-snapshot (https://github.com/apache/flink-kubernetes-operator/blob/main/examples/flink-sql-runner-example/pom.xml#L26). * Once master will evolve to go with flink 1.18-snapshot, it will be built against a new major version than the sample from operator's `release-1.5` branch. * At some point in the future, the Flink APIs may evolve (not necessarily in an incompatible manner), which may lead to changes in operator's sample in the master branch, that users of operator's 1.5 version would consume even if they use the older Flink release. Maybe none of these would be harmful in practice, but in my eyes it would be cleaner / safer if the sample changes would be backported to 1.6. Not necessarily merged now (as your at 1.6 rc2), it could be merged after the release of 1.6.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
