XComp commented on code in PR #23196:
URL: https://github.com/apache/flink/pull/23196#discussion_r1293354755
##########
flink-runtime/src/test/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStoreTest.java:
##########
@@ -79,24 +68,24 @@
* <li>Correct ordering of ZooKeeper and state handle operations
* </ul>
*/
-public class ZooKeeperStateHandleStoreTest extends TestLogger {
+class ZooKeeperStateHandleStoreTest extends TestLogger {
private static final ZooKeeperTestEnvironment ZOOKEEPER = new
ZooKeeperTestEnvironment(1);
Review Comment:
`ZooKeeperExtension` is the JUnit5 way to do things with a ZK test
environment. That would also fix FLINK-26341.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStoreTest.java:
##########
@@ -79,24 +68,24 @@
* <li>Correct ordering of ZooKeeper and state handle operations
* </ul>
*/
-public class ZooKeeperStateHandleStoreTest extends TestLogger {
+class ZooKeeperStateHandleStoreTest extends TestLogger {
Review Comment:
```suggestion
class ZooKeeperStateHandleStoreTest {
```
`TestLogger` is a JUnit4 component and should be removed as part of the
migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
