[
https://issues.apache.org/jira/browse/FLINK-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628532#comment-15628532
]
ASF GitHub Bot commented on FLINK-4939:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86104959
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/CheckpointCommitter.java
---
@@ -98,17 +89,19 @@ public void setOperatorSubtaskId(int id) throws
Exception {
/**
* Mark the given checkpoint as completed in the resource.
*
- * @param checkpointID
+ * @param subtaskIdx the index of the subtask responsible for
committing the checkpoint.
+ * @param checkpointID this id of the checkpoint to be committed.
* @throws Exception
*/
- public abstract void commitCheckpoint(long checkpointID) throws
Exception;
+ public abstract void commitCheckpoint(int subtaskIdx, long
checkpointID) throws Exception;
/**
* Checked the resource whether the given checkpoint was committed
completely.
*
- * @param checkpointID
+ * @param subtaskIdx the index of the subtask responsible for
committing the checkpoint.
+ * @param checkpointID this id of the checkpoint we are interested in.
--- End diff --
this id -> the id
> GenericWriteAheadSink: Decouple the creating from the committing subtask for
> a pending checkpoint
> -------------------------------------------------------------------------------------------------
>
> Key: FLINK-4939
> URL: https://issues.apache.org/jira/browse/FLINK-4939
> Project: Flink
> Issue Type: Improvement
> Components: Cassandra Connector
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.2.0
>
>
> So far the GenericWriteAheadSink expected that
> the subtask that wrote a pending checkpoint to the
> state backend, will be also the one to commit it to
> the third-party storage system.
> This issue targets at removing this assumption. To do this
> the CheckpointCommitter has to be able to dynamically
> take the subtaskIdx as a parameter when asking
> if a checkpoint was committed and also change the
> state kept by the GenericWriteAheadSink to also
> include that subtask index of the subtask that wrote
> the pending checkpoint.
> This change is also necessary for making the operator rescalable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
