1996fanrui commented on code in PR #23203:
URL: https://github.com/apache/flink/pull/23203#discussion_r1294710350
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/WaitingForResourcesTest.java:
##########
@@ -328,19 +260,17 @@ public void
testInternalRunScheduledTasks_correctExecutionOrder() {
ctx.runScheduledTasks();
- assertThat(thirdRun.get(), is(true));
+ assertThat(thirdRun).isTrue();
}
@Test
- public void testInternalRunScheduledTasks_tasksAreRemovedAfterExecution() {
+ void testInternalRunScheduledTasks_tasksAreRemovedAfterExecution() {
MockContext ctx = new MockContext();
AtomicBoolean executed = new AtomicBoolean(false);
Runnable executeOnce =
() -> {
- if (executed.get()) {
- fail("Multiple executions");
- }
+ assertThat(executed).as("Multiple executions").isFalse();
Review Comment:
Thanks for the clarification, I misunderstood this sentence: `That's a bit
out-of-scope for this PR/hotfix commit`.
I undestand now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
