1996fanrui commented on PR #23228: URL: https://github.com/apache/flink/pull/23228#issuecomment-1681973924
Thanks @gaborgsomogyi for the quick feedback. Sorry, I thought it's enough easy and clear, so I didn't explain detailed background and mark it as the `hotfix`. Let me explain it here: 1. The `public put()` method call the `private put()`, and these 2 `put` both call `createBasePathIfNeeded`, it's unnecessary. 2. The `private put` is just called by `putlic put()`, so I removed the `private put()` in this PR. I checked why added 2 `put` methods, because the old interface has 2 `public put` methods. Now it just has one, so I think the `private put()` can be removed as well. <img width="1458" alt="image" src="https://github.com/apache/flink/assets/38427477/fa69f4f7-68aa-4325-a69f-2961e87d10f8";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
