[ 
https://issues.apache.org/jira/browse/FLINK-32275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755842#comment-17755842
 ] 

Hangxiang Yu commented on FLINK-32275:
--------------------------------------

I looked into related interface and implementation, found some implementation 
has to return empty list like UserFacingListState.
Just asĀ FLINK-16310 said, we may need to fix the javadoc.

> The return value of PartitionableListState#get is inconsistent with the 
> requirements of AppendingState
> ------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-32275
>                 URL: https://issues.apache.org/jira/browse/FLINK-32275
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Runtime / State Backends
>            Reporter: Weijie Guo
>            Assignee: Hangxiang Yu
>            Priority: Major
>
> The java doc of {{AppendingState#get()}} states that if the state is empty, 
> then this method should return {{null}}. But for it's child class 
> {{PartitionableListState}}, It does return a empty list instead of {{null}}. 
> This has caused some confusion ,especially {{AppendingState}} is a 
> {{PublicEvolving}} API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to