XComp commented on code in PR #23229:
URL: https://github.com/apache/flink/pull/23229#discussion_r1298127414
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/MultipartUploadExtension.java:
##########
@@ -119,6 +120,12 @@ public void before(ExtensionContext context) throws
Exception {
}
file2 = TempDirUtils.newFile(tmpDirectory);
Files.write(file2.toPath(),
"world".getBytes(ConfigConstants.DEFAULT_CHARSET));
+ file3 = TempDirUtils.newFile(tmpDirectory);
+ try (RandomAccessFile rw = new RandomAccessFile(file3, "rw")) {
+ // magic value that reliably reproduced EndOfDataDecoderException
in hasNext()
+ rw.setLength(1410);
Review Comment:
Ya, it fails for me now quite reliably as well with the fix being
commented-out.
> These things are very susceptible to interference from other requests or
parts of the payload; for example if the JSON payload increases by a single
byte it can already break the number.
Is it worth adding this information to the test method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
